refactor: searchbar rewritten as functional component #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
requested changes
May 14, 2024
kkafar
requested changes
May 14, 2024
There was a problem hiding this comment.
I'm nitpicking here hard, because our attention won't be back to this component for some time most likely.
Have you tested this on our example apps (there is dedicated screen in Example & FabricExample for the search bar API I believe) whether everything works fine?
tboba
requested changes
May 14, 2024
alduzy
force-pushed
the
@alduzy/convert-searchbar-to-fn
branch
from
fd0ecd5 to
33cc656
Compare
kkafar
reviewed
May 15, 2024
|
I've tested the changes on Example app both on android and iOS and it works just like before. I didn't find any usage of the searchbar in FabricExample. |
kkafar
approved these changes
May 15, 2024
This was referenced Jul 17, 2024
This was referenced Aug 20, 2024
This was referenced Aug 23, 2024
This was referenced Aug 30, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…on#2132) ## Description This PR intents to change SearchBar component into a functional component. ## Changes Rewritten SearchBar component as function leveraging useImperativeHandle to apply new methods <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intents to change SearchBar component into a functional component.
Changes
Rewritten SearchBar component as function leveraging useImperativeHandle to apply new methods
Test code and steps to reproduce
Checklist