Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reinstall pods in examples after release #2192

Merged
merged 5 commits into from
Jun 19, 2024
Merged

chore: reinstall pods in examples after release #2192

merged 5 commits into from
Jun 19, 2024

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Jun 18, 2024 •
edited
Loading

Description

So that this does not come up randomly in various PRs as unrelated changes.

Changes

  • Bump in TE
  • Bump in FTE
  • Bump in Example
  • Bump in FabricExample
  • Bump in TVOSExample

Test code and steps to reproduce

N/A

Checklist

  • Ensured that CI passes

@kkafar kkafar requested review from tboba, alduzy and maciekstosio June 18, 2024 13:45
tboba
tboba reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about FabricExample? Have you also yarned all the projects? 😄

@tboba
Copy link
Member

tboba commented Jun 18, 2024

I'm also observing a new type of error in our E2E tests. @kirillzyusko do you have similar behavior with your runners?

@kirillzyusko
Copy link
Contributor

@tboba no, because I switched to linux machine (which is more powerful than a Mac runner) and all these random crashes went away 🙂

This is the first migration step that I made (https://github.com/kirillzyusko/react-native-keyboard-controller/pull/352/files#diff-7efeb6f32b8d7e3c36b551280577125c625c730580191805e78a3f2482a513bd) and this is the second change (https://github.com/kirillzyusko/react-native-keyboard-controller/pull/353/files#diff-7efeb6f32b8d7e3c36b551280577125c625c730580191805e78a3f2482a513bd)

After that Android tests are more stable than iOS 😂

@kkafar
Copy link
Member Author

kkafar commented Jun 18, 2024

What about FabricExample? Have you also yarned all the projects? 😄

you're absolutely right @tboba, I've somehow overlooked it - my bad. Fixed in 54f53a4.

@kkafar kkafar requested a review from tboba June 18, 2024 15:04
@kkafar
Copy link
Member Author

kkafar commented Jun 19, 2024

I'm merging, as there weren't more objections to handle. If you have some more remarks let me know, I'll fixup in followup.

@kkafar kkafar merged commit 81cd573 into main Jun 19, 2024
7 of 8 checks passed
@kkafar kkafar deleted the @kkafar/update-examples branch June 19, 2024 10:33
alduzy pushed a commit that referenced this pull request Jun 28, 2024
@kkafar @alduzy
chore: reinstall pods in examples after release (#2192)
8717c11 
## Description

So that this does not come up randomly in various PRs as unrelated
changes.

## Changes

- **Bump in TE**
- **Bump in FTE**
- **Bump in Example**
- **Bump in FabricExample**
- **Bump in TVOSExample**

## Test code and steps to reproduce

N/A

## Checklist

- [ ] Ensured that CI passes
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@shonore shonore mentioned this pull request Aug 22, 2024
Open
@2lambda123 2lambda123 mentioned this pull request Aug 22, 2024
Merged
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Closed
This was referenced Aug 23, 2024
Open
Open
Open
Open
@2lambda123 2lambda123 mentioned this pull request Aug 26, 2024
Merged
This was referenced Aug 27, 2024
Open
Open
Open
This was referenced Aug 30, 2024
Open
Open
Open
Open
Open
@undrthegraveyard undrthegraveyard mentioned this pull request Sep 4, 2024
Closed
@asraful-cse asraful-cse mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 22, 2024
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
@Ayush-Bulbule Ayush-Bulbule mentioned this pull request Oct 2, 2024
Merged
@tobistudio tobistudio mentioned this pull request Oct 3, 2024
Open
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
@kkafar @ja1ns
chore: reinstall pods in examples after release (software-mansion#2192)
d38b747 
## Description

So that this does not come up randomly in various PRs as unrelated
changes.

## Changes

- **Bump in TE**
- **Bump in FTE**
- **Bump in Example**
- **Bump in FabricExample**
- **Bump in TVOSExample**

## Test code and steps to reproduce

N/A

## Checklist

- [ ] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alduzy alduzy alduzy approved these changes

@maciekstosio maciekstosio Awaiting requested review from maciekstosio

@tboba tboba Awaiting requested review from tboba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkafar @tboba @kirillzyusko @alduzy