refactor!: drop support for native-stack v5 #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and add notes to README and CONTRIBUTION guide
kkafar
commented
Oct 17, 2024
There was a problem hiding this comment.
I've left few directions for you @maciekstosio, thanks for taking care of this!
README.md
Outdated
Comment on lines
136
to
137
| > [!CAUTION] | ||
| > NativeStack has been moved from react-native-screens/native-stack to @react-navigation/native since version v6. With react-native-screens v4 native stack v5 (react-native-screens/native-stack) is deprecated and marked for removal in the upcoming minor release, react-native-screens will support only @react-navigation/native-stack v7. |
There was a problem hiding this comment.
Suggested change
| > [!CAUTION] | |
| > NativeStack has been moved from react-native-screens/native-stack to @react-navigation/native since version v6. With react-native-screens v4 native stack v5 (react-native-screens/native-stack) is deprecated and marked for removal in the upcoming minor release, react-native-screens will support only @react-navigation/native-stack v7. | |
| > [!CAUTION] | |
| > NativeStack has been moved from react-native-screens/native-stack to @react-navigation/native since version v6. With react-native-screens v4 native stack v5 (react-native-screens/native-stack) is deprecated and marked for removal in the upcoming minor release, react-native-screens v4 will support only @react-navigation/native-stack v7. |
native-stack/README.md
Outdated
There was a problem hiding this comment.
We want to restore this file now and put the same disclaimer in "caution style" there.
native-stack/package.json
Outdated
There was a problem hiding this comment.
We need to restore this also
kkafar
commented
Oct 22, 2024
There was a problem hiding this comment.
I think we're good to go.
@maciekstosio approve if you agree
maciekstosio
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intents to remove native-stack v5 implementation from the repository.Plan:
Remove public/native-stackdirectoryRemove implementation insrc/native-stack/directoryRemove all references in docs tonative-stack@v5Remove all in-code references tonative-stack@v5Caution
2 & 4 require some more work to be done, because screen transitions API code (integration with reanimated) makes use of API exposed bynative-stack@v5.I need to figure out how to decouple these first.The plan has changed. We now intend to mark native-stack@v5 and deprecated and destined for removal with one of upcoming minor versions of the library after initial 4.0.0 release. For the time before removal native-stack@v5 will be shipped with few minor versions of screens v4 line, however it won't be supported and should be considered broken (and it is, if you're using native-header).
Important
This change breaks
TestScreenAnimationas this test requires screen transition API which is not yet ported to v7.Changes
Mark types & factory functions of native stack v5 as deprecated and add comments explaining our approach.
Test code and steps to reproduce
N/A
Checklist