fix(iOS): do not force API user to set activityState
#2406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We did not set default value of
activityState
on iOS. It was set to0
by defaultint
initializer.In
Screen
component native spec we set it to-1
, however this had no impact, because the value settersetActivityStateOrNil:
filtered out the-1
value.TODO:
^ Looks like this will work, because navigators such as bottom tabs always set the activity state explicitly.
This is a problem, because now, after adding preload support #2389 we filter out screens with
activityState == 0
in native stack.Therefore, we now unintentionally force our API user to always set desired
activityState
.Fixes #2405
Changes
Set
activityState
to-1
by default on native side.Test code and steps to reproduce
Just render screen inside native-stack w/o
activityState
set. It won't be shown.Checklist