fix: prevent Require cycles warning #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alduzy
changed the title
maciekstosio
approved these changes
Oct 16, 2024
WoLewicki
reviewed
Oct 16, 2024
kkafar
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
I think we should be good here.
One thing we might wanna do, as mentioned by @WoLewicki is to test the lib in external fresh app. After we've done that I think we're good to go. Thank you!
alduzy
added a commit
that referenced
this pull request
Oct 31, 2024
This PR fixes `require cycles` warning caused by importing from `react-native-screens` in a `react-native-screens` module by changing the imports to relative. Fixes #2408 . - changed imports to relative <!-- Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. --> <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> - [x] Ensured that CI passes
1 task
alduzy
added a commit
that referenced
this pull request
Oct 31, 2024
This PR fixes `require cycles` warning caused by importing from `react-native-screens` in a `react-native-screens` module by changing the imports to relative. Fixes #2408 . - changed imports to relative <!-- Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. --> <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> - [x] Ensured that CI passes (cherry picked from commit d5197b6)
alduzy
added a commit
that referenced
this pull request
Oct 31, 2024
This is a #2410 cherry-pick from main. This PR aims to bring the fix to v3 as well. ## Description This PR fixes `require cycles` warning caused by importing from `react-native-screens` in a `react-native-screens` module by changing the imports to relative. Additionally it fixes an [issue](#2302) with react-compiler in expo projects. Fixes #2408 #2302. ## Checklist - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
require cycleswarning caused by importing fromreact-native-screensin areact-native-screensmodule by changing the imports to relative.Fixes #2408 .
Changes
Test code and steps to reproduce
Checklist