fix: remove workaround for removing clipped subviews #2596
+4,138
−5,538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could not get the project to compile without this file. Tried cleaning caches, nuking derived data, Pods, build directory etc. It just has to be there for some reason 🤷 I do not know also why XCode duplicates this file...
## Description This is required for RN 0.77 apparently. TurboReactPackage is deprecated on new arch. No idea why. I am not sure about backwards compatibility either, sorry. Feel free to close this PR if this isn't backwards compatible. <!-- Description and motivation for this PR. Include Fixes #<number> if this is fixing some issue. Fixes # . --> ## Changes <!-- Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Updated `about.md` docs --> <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
The change is required because BaseViewManagerInterface has been removed in facebook/react-native#46809 and we need this to keep the lib working on old architecture with react-native 0.77+. This change, according to the PR is supposed to be backward compatible (older versions of react-native) should work with these new codegen specs.
I've removed dependency on gesturehandler few commits before and presence of this patch caused the CI to fail. We need to check out more recent gesturehandler versions anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the workaround introduced in series of PRs (listed chronologically here):
For detailed description of error mechanism and broader discussion please refer to:
tldr: When popping screen on Fabric we marked the views as "transitioning" and this led to view being effectively miscounted
during removal by view groups that supported react-native's subview clipping mechanism.
The issue has been present most likely in every version of the library when running on Android & Fabric, but it arose few months ago due to broader
adoption of the new architecture.
facebook/react-native#47634 is supposed to fix the underlying issue in
react-native'score.Changes
Removed the workaround code from
Screenimplementation on Android.The
has been released with 0.77.0-rc.3 and followup small fixup:
has been released with 0.77.0-rc.4.
Therefore, with landing this PR we should limit our support on Fabric to 0.77.0.
Test code and steps to reproduce
Test2282- note that there are few testing variants available there, you just need to comment (out) some parts of the code.Checklist