Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in RNSVGImageShadowNode::initialStateData #2079

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

hsjoberg
Copy link
Contributor

@hsjoberg hsjoberg commented Jul 1, 2023

Summary

This PR solves #2077.
I'm too bad at C++ to know whether this is idiomatic code, however.

Checklist

  • I have tested this on a device and a simulator

Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you answer the comment? Besides this, the PR looks correct, thanks!

@hsjoberg
Copy link
Contributor Author

hsjoberg commented Jul 4, 2023

Alright, I've changed to {} instead.

@khanakia
Copy link

khanakia commented Jul 4, 2023

Can we merge it soon please? I am unable to upgrade my react-native to 0.72.1 version because of this issue

@hsjoberg
Copy link
Contributor Author

hsjoberg commented Jul 4, 2023

@khanakia If you need this fix immediately you can change your package.json like this, which will point to the commit in this PR:

"react-native-svg": "git+https://github.com/hsjoberg/react-native-svg.git#7ac1a17c4bce907be46c349f345a29b439c5e3dd",

But don't forget to change back to an official react-native-svg version once this one gets merged and published.

@khanakia
Copy link

khanakia commented Jul 4, 2023

Thanks

Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🚀

@WoLewicki WoLewicki merged commit 50b555c into software-mansion:main Jul 5, 2023
@Happy-2002
Copy link

Happy-2002 commented Jul 18, 2023

Solution
Please remove {} in this line -- return {imageSource, {imageSource, nullptr,{}}};
Replace -- return {imageSource, {imageSource, nullptr,}};

grahammendick added a commit to grahammendick/navigation that referenced this pull request Sep 11, 2023
See software-mansion/react-native-svg#2079
Pretty sure this broke in React Native 0.72.1
renovate bot referenced this pull request in valora-inc/wallet Oct 19, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-svg](https://togithub.com/react-native-community/react-native-svg)
| [`^13.9.0` ->
`^13.14.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.9.0/13.14.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-svg/13.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-svg/13.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-svg/13.9.0/13.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-svg/13.9.0/13.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>react-native-community/react-native-svg
(react-native-svg)</summary>

###
[`v13.14.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.14.0)

[Compare
Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.13.0...v13.14.0)

PR adding improvements to the library. Thanks for all your contributions
🚀

#### What's Changed

- Create FUNDING.yml by [@&#8203;aleqsio](https://togithub.com/aleqsio)
in
[https://github.com/software-mansion/react-native-svg/pull/2133](https://togithub.com/software-mansion/react-native-svg/pull/2133)
- docs: Update deprecated expo install instructions to \`npx expo
install´ by
[@&#8203;GabrieldosSantosOliveira](https://togithub.com/GabrieldosSantosOliveira)
in
[https://github.com/software-mansion/react-native-svg/pull/2128](https://togithub.com/software-mansion/react-native-svg/pull/2128)
- \[macOS]\[Xcode 15] Avoid using dirtyRect in `drawRect:` by
[@&#8203;Saadnajmi](https://togithub.com/Saadnajmi) in
[https://github.com/software-mansion/react-native-svg/pull/2136](https://togithub.com/software-mansion/react-native-svg/pull/2136)
- fix: error for transform on web by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2139](https://togithub.com/software-mansion/react-native-svg/pull/2139)
- chore(deps): bump activesupport from 6.1.7.4 to 7.0.7.2 in
/TestsExample by [@&#8203;dependabot](https://togithub.com/dependabot)
in
[https://github.com/software-mansion/react-native-svg/pull/2122](https://togithub.com/software-mansion/react-native-svg/pull/2122)
- fix: web not working with reanimated in example by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2140](https://togithub.com/software-mansion/react-native-svg/pull/2140)

#### New Contributors

- [@&#8203;aleqsio](https://togithub.com/aleqsio) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2133](https://togithub.com/software-mansion/react-native-svg/pull/2133)
-
[@&#8203;GabrieldosSantosOliveira](https://togithub.com/GabrieldosSantosOliveira)
made their first contribution in
[https://github.com/software-mansion/react-native-svg/pull/2128](https://togithub.com/software-mansion/react-native-svg/pull/2128)
- [@&#8203;Saadnajmi](https://togithub.com/Saadnajmi) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2136](https://togithub.com/software-mansion/react-native-svg/pull/2136)

**Full Changelog**:
software-mansion/react-native-svg@v13.13.0...v13.14.0

###
[`v13.13.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.13.0)

[Compare
Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.12.0...v13.13.0)

Minor release restoring usage of
`UIGraphicsBeginImageContextWithOptions` on `macOS` since there is no
implementation for `UIGraphicsImageRendererFormat` there yet.

#### What's Changed

- feat: add macos back to Example app by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2119](https://togithub.com/software-mansion/react-native-svg/pull/2119)

**Full Changelog**:
software-mansion/react-native-svg@v13.12.0...v13.13.0

###
[`v13.12.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.12.0)

[Compare
Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.11.0...v13.12.0)

Minor release introducing the change of API used on `iOS` from
[UIGraphicsBeginImageContextWithOptions](https://developer.apple.com/documentation/uikit/1623912-uigraphicsbeginimagecontextwitho)
to
[UIGraphicsImageRenderer](https://developer.apple.com/documentation/uikit/uigraphicsimagerenderer).

#### What's Changed

- feat: remove UIGraphicsBeginImageContextWithOptions from repo by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2117](https://togithub.com/software-mansion/react-native-svg/pull/2117)

**Full Changelog**:
software-mansion/react-native-svg@v13.11.0...v13.12.0

###
[`v13.11.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.11.0)

[Compare
Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.10.0...v13.11.0)

Minor release cleaning the repository 🧹 Please submit any issues that
come up with the newest version 🐛 Thanks for your contributions 🚀

#### What's Changed

- fix: make web platform types compatible with native types by
[@&#8203;nderscore](https://togithub.com/nderscore) in
[https://github.com/software-mansion/react-native-svg/pull/2091](https://togithub.com/software-mansion/react-native-svg/pull/2091)
- docs: update usage.md for react-native 0.72 by
[@&#8203;Letty](https://togithub.com/Letty) in
[https://github.com/software-mansion/react-native-svg/pull/2104](https://togithub.com/software-mansion/react-native-svg/pull/2104)
- docs: update README.md by [@&#8203;Mhp23](https://togithub.com/Mhp23)
in
[https://github.com/software-mansion/react-native-svg/pull/2110](https://togithub.com/software-mansion/react-native-svg/pull/2110)
- fix: bump packages, eslint, tsconfig, prettier and resolve all
conflicts by [@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2114](https://togithub.com/software-mansion/react-native-svg/pull/2114)

#### New Contributors

- [@&#8203;nderscore](https://togithub.com/nderscore) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2091](https://togithub.com/software-mansion/react-native-svg/pull/2091)
- [@&#8203;Letty](https://togithub.com/Letty) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2104](https://togithub.com/software-mansion/react-native-svg/pull/2104)
- [@&#8203;Mhp23](https://togithub.com/Mhp23) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2110](https://togithub.com/software-mansion/react-native-svg/pull/2110)

**Full Changelog**:
software-mansion/react-native-svg@v13.10.0...v13.11.0

###
[`v13.10.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.10.0)

[Compare
Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.9.0...v13.10.0)

Minor release fixing some long-standing issues, adding new features such
as web support for `toDataURL`
([https://github.com/software-mansion/react-native-svg/pull/2072](https://togithub.com/software-mansion/react-native-svg/pull/2072))
and `fallback` prop for `SvgXml` and others
([https://github.com/software-mansion/react-native-svg/pull/2071](https://togithub.com/software-mansion/react-native-svg/pull/2071)).
It also adds support for RN 0.72 on **new architecture**, at the same
time dropping the support for RN 0.71 there. Thanks for all your
contributions 🚀

#### What's Changed

- Fix compilation errors on Windows by
[@&#8203;christophpurrer](https://togithub.com/christophpurrer) in
[https://github.com/software-mansion/react-native-svg/pull/2045](https://togithub.com/software-mansion/react-native-svg/pull/2045)
- Fix setNativeProps type by
[@&#8203;fauri13](https://togithub.com/fauri13) in
[https://github.com/software-mansion/react-native-svg/pull/2058](https://togithub.com/software-mansion/react-native-svg/pull/2058)
- fix: remove deprecated import from react-native-web by
[@&#8203;janlat](https://togithub.com/janlat) in
[https://github.com/software-mansion/react-native-svg/pull/2027](https://togithub.com/software-mansion/react-native-svg/pull/2027)
- fix: Updating iOS version
[#&#8203;2038](https://togithub.com/react-native-community/react-native-svg/issues/2038)
by [@&#8203;sgabriel](https://togithub.com/sgabriel) in
[https://github.com/software-mansion/react-native-svg/pull/2041](https://togithub.com/software-mansion/react-native-svg/pull/2041)
- Fix syntax error in RNSVGImageShadowNode::initialStateData by
[@&#8203;hsjoberg](https://togithub.com/hsjoberg) in
[https://github.com/software-mansion/react-native-svg/pull/2079](https://togithub.com/software-mansion/react-native-svg/pull/2079)
- Fix
[#&#8203;1345](https://togithub.com/react-native-community/react-native-svg/issues/1345):
opacity does not work with currentColor on Android by
[@&#8203;laptou](https://togithub.com/laptou) in
[https://github.com/software-mansion/react-native-svg/pull/2080](https://togithub.com/software-mansion/react-native-svg/pull/2080)
- chore: bump Example to 0.72 by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2084](https://togithub.com/software-mansion/react-native-svg/pull/2084)
- chore(deps): bump fast-xml-parser from 4.1.3 to 4.2.4 in /TestsExample
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-svg/pull/2063](https://togithub.com/software-mansion/react-native-svg/pull/2063)
- chore(deps): bump vm2 from 3.9.14 to 3.9.19 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-svg/pull/2056](https://togithub.com/software-mansion/react-native-svg/pull/2056)
- chore(deps): bump fast-xml-parser from 4.2.4 to 4.2.5 in /TestsExample
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-svg/pull/2085](https://togithub.com/software-mansion/react-native-svg/pull/2085)
- Add web support for toDataURL() on svg tags by
[@&#8203;chrispader](https://togithub.com/chrispader) in
[https://github.com/software-mansion/react-native-svg/pull/2072](https://togithub.com/software-mansion/react-native-svg/pull/2072)
- Prevents SvgUri crashes when uri is invalid and adds fallback prop by
[@&#8203;PiotrWszolek](https://togithub.com/PiotrWszolek) in
[https://github.com/software-mansion/react-native-svg/pull/2071](https://togithub.com/software-mansion/react-native-svg/pull/2071)
- chore: run prettier and lint by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2087](https://togithub.com/software-mansion/react-native-svg/pull/2087)
- chore: bump TestsExample to 0.72 by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2088](https://togithub.com/software-mansion/react-native-svg/pull/2088)
- feat: strokeDasharray with Animated by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2089](https://togithub.com/software-mansion/react-native-svg/pull/2089)

#### New Contributors

- [@&#8203;christophpurrer](https://togithub.com/christophpurrer) made
their first contribution in
[https://github.com/software-mansion/react-native-svg/pull/2045](https://togithub.com/software-mansion/react-native-svg/pull/2045)
- [@&#8203;fauri13](https://togithub.com/fauri13) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2058](https://togithub.com/software-mansion/react-native-svg/pull/2058)
- [@&#8203;janlat](https://togithub.com/janlat) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2027](https://togithub.com/software-mansion/react-native-svg/pull/2027)
- [@&#8203;sgabriel](https://togithub.com/sgabriel) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2041](https://togithub.com/software-mansion/react-native-svg/pull/2041)
- [@&#8203;laptou](https://togithub.com/laptou) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2080](https://togithub.com/software-mansion/react-native-svg/pull/2080)
- [@&#8203;chrispader](https://togithub.com/chrispader) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2072](https://togithub.com/software-mansion/react-native-svg/pull/2072)
- [@&#8203;PiotrWszolek](https://togithub.com/PiotrWszolek) made their
first contribution in
[https://github.com/software-mansion/react-native-svg/pull/2071](https://togithub.com/software-mansion/react-native-svg/pull/2071)

**Full Changelog**:
software-mansion/react-native-svg@v13.9.0...v13.10.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants