Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up temporary salted contracts used in tests #400

Closed
DelevoXDG opened this issue Jan 30, 2024 · 0 comments · Fixed by #401
Closed

Clean up temporary salted contracts used in tests #400

DelevoXDG opened this issue Jan 30, 2024 · 0 comments · Fixed by #401
Labels
enhancement New feature or request priority: low tests

Comments

@DelevoXDG
Copy link
Contributor

Feature Request

ScarbClient.createSaltedContract currently changes the contents of salted_<contract_name>.cairo, which results in several files tracked by git changing and not returning to their original state.
@DelevoXDG DelevoXDG changed the title Clean up temporary salted contracts used in test Clean up temporary salted contracts used in tests Jan 30, 2024
DelevoXDG added a commit that referenced this issue Jan 30, 2024
@DelevoXDG
Fix #400
9f36a51 
- Update ScarbClient
  - make createSaltedContract private
  - add @synchronized buildSaltedContract; write original source code before exit
- Update tests
@DelevoXDG DelevoXDG mentioned this issue Jan 30, 2024
Merged
1 task
DelevoXDG added a commit that referenced this issue Jan 30, 2024
@DelevoXDG
Fix #400
afc17f7 
- Update ScarbClient
  - make createSaltedContract private
  - add @synchronized buildSaltedContract; write original source code before exit
- Update tests
DelevoXDG added a commit that referenced this issue Jan 31, 2024
@DelevoXDG
Fix #400 (#401)
c843fb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority: low tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #400 software-mansion/starknet-jvm
1 participant
@DelevoXDG