Support RPC 0.6.0 #358
Merged
Support RPC 0.6.0 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelevoXDG
commented
Nov 22, 2023
| @@ -33,6 +33,15 @@ enum class TransactionType(val txPrefix: Felt) { | |||
| L1_HANDLER(Felt.fromHex("0x6c315f68616e646c6572")), // encodeShortString('l1_handler') | |||
| } | |||
|
|
|||
| @Serializable | |||
| enum class DAMode { | |||
There was a problem hiding this comment.
It's DA_MODE in the spec, but naming this DAMode seems very non-java, so maybe we should deviate from the spec a bit and rename it to DataAvailabilityMode?
|
Blocked by #326 |
…tions to StandardAccount
DelevoXDG
commented
Dec 13, 2023
Comment on lines
+62
to
+83
| fun toMaxFee(overhead: Double = 0.5): Felt { | ||
| return addOverhead(overallFee.value, overhead).toFelt | ||
| } | ||
|
|
||
| fun toResourceBounds( | ||
| amountOverhead: Double = 0.1, | ||
| unitPriceOverhead: Double = 0.5, | ||
| ): ResourceBoundsMapping { | ||
| val maxAmount = addOverhead(gasConsumed.value, amountOverhead).toUint64 | ||
| val maxPricePerUnit = addOverhead(gasPrice.value, unitPriceOverhead).toUint128 | ||
|
|
||
| // As of Starknet 0.13.0, the L2 gas is not supported | ||
| // Because of this, the L2 gas values are hardcoded to 0 | ||
| return ResourceBoundsMapping( | ||
| l1Gas = ResourceBounds(maxAmount = maxAmount, maxPricePerUnit = maxPricePerUnit), | ||
| l2Gas = ResourceBounds(maxAmount = Uint64.ZERO, maxPricePerUnit = Uint128.ZERO), | ||
| ) | ||
| } | ||
| private fun addOverhead(value: BigInteger, overhead: Double): BigInteger { | ||
| val multiplier = ((1 + overhead) * 100).roundToInt().toBigInteger() | ||
| return value.multiply(multiplier).divide(BigInteger.valueOf(100)) | ||
| } |
There was a problem hiding this comment.
We typically don't define several methods inside files with just dataclasses.
However, I think the way it was done (just plain function), is sub-optimal, since we shouldn't really get max fee or resource bounds without having estimate response.
We could:
- move this particular response to separate file
- define those methods as extensions
There was a problem hiding this comment.
let's make an issue and think about it at later date
DelevoXDG
commented
Dec 13, 2023
Comment on lines
+449
to
+456
| companion object { | ||
| @field:JvmField | ||
| val ZERO = ResourceBounds(Uint64.ZERO, Uint128.ZERO) | ||
| } | ||
|
|
||
| fun toMaxFee(): Felt { | ||
| return maxAmount.value.multiply(maxPricePerUnit.value).toFelt | ||
| } |
There was a problem hiding this comment.
Similar as above, convenience methods that could be changed to extensions, moved to another file or left as is.
THenry14
reviewed
Dec 13, 2023
THenry14
reviewed
Dec 13, 2023
THenry14
reviewed
Dec 13, 2023
THenry14
reviewed
Dec 13, 2023
Co-authored-by: Wojciech Szymczyk <[email protected]>
Co-authored-by: Wojciech Szymczyk <[email protected]>
THenry14
reviewed
Dec 13, 2023
lib/src/main/kotlin/com/swmansion/starknet/data/serializers/NumAsHexSerializers.kt
Show resolved
Hide resolved
THenry14
approved these changes
Dec 13, 2023
This was referenced Dec 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
instead of deploying one
InvokeTransactionPayload->InvokeTransactionV1PayloadDeployAccountTransactionPayload->DeployAccountTransactionV1PayloadAccountandStandardAccount: add methods to support v3 transactionsParams.ktExecutionParamsto itParamsV3ExecutionParamsV3DeclareParamsV3DeployAccountParamsV3signvariations for signing v3 invoke transactionssignDeployAccountvariations for signing v3 deploy account transactionssignDeclarevariations for signing v3 declare transactionsexecuteV3for singing and sending v3 invoke transactionsestimateFeeV3for estimating fee of v3 transactionsAccountinterface to make methods more coherentProviderandStandardProvider:SimulationFlagForEstimateFeeSKIP_VALIDATEby defaultAccount,Provider)TransactionHashCalculatorNumAsHexBasetypes:Uint64,Uint128NumAsHexSerializer,FeltSerializer, addUint128SerializerandUint64SerializerUint256conform toNumAsHexbaseTransactionPayloadSerilalizerEstimateFeeResponseResourcePrice:priceInStark->princeInFriPriceUnitResourceBoundsandResourceBoundsMappingExecutionResources: all fields changed fromNumAsHextoint; addsegmentArenaApplicationsFunctionInvocation(trace API): addexecution_resourcesDAModeLinked issues
Closes #356
Breaking changes