Add ByteArray #436
Merged
Add ByteArray #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `StarknetByteArray` - Move logic for encoding long string from `TypedData.prepareLongString()` to `StarknetByteArray` - Fix logic to properly handle short strings <31 - Do not prepend `Felt.ZERO` to `StarknetByteArray.data`
- Remains to be verified if it's correct one
This reverts commit 03363b3. It was confirmed that logic from the docs should be used: starknet-io/starknet.js#1003 (comment)
DelevoXDG
commented
Mar 13, 2024
lib/src/main/kotlin/com/swmansion/starknet/data/types/StarknetByteArray.kt
Show resolved
Hide resolved
THenry14
reviewed
Mar 14, 2024
lib/src/main/kotlin/com/swmansion/starknet/data/types/StarknetByteArray.kt
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/types/StarknetByteArray.kt
Show resolved
Hide resolved
THenry14
approved these changes
Mar 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 70.37% 70.56% +0.18%
==========================================
Files 73 75 +2
Lines 3153 3176 +23
Branches 309 313 +4
==========================================
+ Hits 2219 2241 +22
Misses 788 788
- Partials 146 147 +1 ☔ View full report in Codecov by Sentry. |
THenry14
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Related to and is needed for #428
StarknetTypedDatathat corresponds toByteArraystruct in CairoLinked issues
Closes
Breaking changes
References