Fix build for android #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `BigInteger.valueOf(2)` instead - Reason: not supported in Java 1.8
- Update `NativeLoader` to handle `System.getProperty()` returning null
- Bump `org.bouncycastle:bcprov-jdk18on` to 1.77 - Bump `com.squareup.okhttp3:okhttp` to 4.12.0
- Remove unnecessary parenthesis; Use strings
THenry14
approved these changes
Mar 20, 2024
lib/src/main/kotlin/com/swmansion/starknet/crypto/NativeLoader.kt
Outdated
Show resolved
Hide resolved
| implementation 'org.bouncycastle:bcprov-jdk18on:1.76' | ||
| implementation("com.squareup.okhttp3:okhttp:4.11.0") | ||
| implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.5.1") | ||
| implementation 'org.bouncycastle:bcprov-jdk18on:1.77' |
There was a problem hiding this comment.
have you tried to build it locally + run the demo? I vaguely remember we had some problems last time we tried to bump some deps
There was a problem hiding this comment.
Yeah, it now builds locally with no errors.
As for the demo, we'd need to do #389 and as of now, it would be much easier to test demo once we actually release the new version.
Co-authored-by: Wojciech Szymczyk <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 71.17% 71.12% -0.06%
==========================================
Files 75 75
Lines 3337 3338 +1
Branches 366 367 +1
==========================================
- Hits 2375 2374 -1
- Misses 797 798 +1
- Partials 165 166 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix errors and warnings observed when running
:android:compileDebugKotlinthat caused 0.11.1 release to fail.BigInteger.TWO: not supported in Java 1.8androiddepskotlin-reflectNativeLoaderto handleSystem.getProperty()returning nullLinked issues
Closes
Breaking changes