Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return only hash in TypeData.encodeValue() #483

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Return only hash in TypeData.encodeValue() #483

merged 1 commit into from
Jun 3, 2024

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Jun 3, 2024 •
edited
Loading

Describe your changes

  • Change TypedData.encodeValue(...): Pair<String, Felt> to TypedData.encodeValue(...): Felt

Linked issues

Closes #450

Breaking changes

  • This issue contains breaking changes

@franciszekjob franciszekjob requested a review from ddoktorski June 3, 2024 10:07
ddoktorski
ddoktorski approved these changes Jun 3, 2024
View reviewed changes
Copy link

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciszekjob franciszekjob merged commit c9df29a into main Jun 3, 2024
2 checks passed
@franciszekjob franciszekjob deleted the chore/450-refactor-typed-data-encode-value branch June 4, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return only hash in TypeData.encodeValue()
2 participants
@franciszekjob @ddoktorski