Fix access to underlying request in PlayServerInterpreter #1496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Play's
Request
may contain additional context like authentication when it is produced byActionBuilder
. Access to that data was possible it Tapir 0.18.1 by castingServerRequest.underlying
to type that is produced bydefaultActionBuilder
.Unfortunately, this was broken in 0.18.3. Fix in #1423 replaced
Request
withRequestHeader
that misses that context.This pull request provider better fix for #1400, that fixes that problem without affecting
underlying
. In Play Framework, anyRequest
extendsRequestHeader
, so this change is backward compatible and should no break code that works with 0.18.3.