Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access to underlying request in PlayServerInterpreter #1496

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

maxcom
Copy link
Contributor

@maxcom maxcom commented Sep 21, 2021

Play's Request may contain additional context like authentication when it is produced by ActionBuilder. Access to that data was possible it Tapir 0.18.1 by casting ServerRequest.underlying to type that is produced by defaultActionBuilder.

Unfortunately, this was broken in 0.18.3. Fix in #1423 replaced Request with RequestHeader that misses that context.

This pull request provider better fix for #1400, that fixes that problem without affecting underlying. In Play Framework, any Request extends RequestHeader, so this change is backward compatible and should no break code that works with 0.18.3.

@adamw adamw merged commit e4d7ac0 into softwaremill:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants