Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Refactor - Moves runtime_environment_key out of Config into a static variable #492

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Jul 31, 2023

Having runtime_environment_key inside Config is a bit of leaky abstraction as it requires the outside user to choose a key randomly and according to PROGRAM_ENVIRONMENT_KEY_SHIFT. It also prevents Config::eq from working properly as two identical configs but with different random keys would be considered different.

@codecov-commenter
Copy link

Codecov Report

Merging #492 (161e5c9) into main (2fe4357) will decrease coverage by 0.01%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   89.65%   89.64%   -0.01%     
==========================================
  Files          23       23              
  Lines       10145    10150       +5     
==========================================
+ Hits         9095     9099       +4     
- Misses       1050     1051       +1     
Files Changed Coverage Δ
src/jit.rs 92.45% <91.66%> (-0.05%) ⬇️
src/vm.rs 73.36% <100.00%> (-0.12%) ⬇️

@Lichtso Lichtso force-pushed the refactor/move_runtime_environment_key_into_static branch from 161e5c9 to 7cafa71 Compare July 31, 2023 11:27
@Lichtso Lichtso merged commit 42e5b3b into main Aug 3, 2023
@Lichtso Lichtso deleted the refactor/move_runtime_environment_key_into_static branch August 3, 2023 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants