Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Negative error codes now get decoded correctly by the production error decoder #2376

Conversation

steveluscher
Copy link
Contributor

@steveluscher steveluscher commented Mar 23, 2024

Test Plan

cd packages/errors/
pnpm turbo compile:js
npx . decode -- -32003

[Decoded] Solana error code #-32003
    - Transaction signature verification failure

Closes #2357.

Copy link

changeset-bot bot commented Mar 23, 2024

🦋 Changeset detected

Latest commit: e9e0048

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@solana/errors Patch
@solana/accounts Patch
@solana/addresses Patch
@solana/assertions Patch
@solana/codecs-core Patch
@solana/codecs-data-structures Patch
@solana/codecs-numbers Patch
@solana/codecs-strings Patch
@solana/compat Patch
@solana/instructions Patch
@solana/keys Patch
@solana/web3.js-experimental Patch
@solana/rpc-api Patch
@solana/rpc-spec Patch
@solana/rpc-subscriptions-spec Patch
@solana/rpc-subscriptions-transport-websocket Patch
@solana/rpc-subscriptions Patch
@solana/rpc-transport-http Patch
@solana/rpc-types Patch
@solana/rpc Patch
@solana/signers Patch
@solana/sysvars Patch
@solana/transaction-confirmation Patch
@solana/transactions Patch
@solana/web3.js-legacy-sham Patch
@solana/programs Patch
@solana/rpc-graphql Patch
@solana/rpc-parsed-types Patch
@solana/rpc-subscriptions-api Patch
@solana/codecs Patch
@solana/options Patch
@solana/rpc-transformers Patch
@solana/functional Patch
@solana/rpc-spec-types Patch
@solana/webcrypto-ed25519-polyfill Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite Graphite

@steveluscher steveluscher added the automerge Merge this Pull Request automatically once CI passes label Mar 23, 2024
@steveluscher steveluscher requested a review from mcintyre94 March 23, 2024 06:58
@mergify mergify bot merged commit 9370133 into master Mar 23, 2024
8 checks passed
@mergify mergify bot deleted the 03-23-negative_error_codes_now_get_decoded_correctly_by_the_production_error_decoder branch March 23, 2024 06:59
Copy link
Contributor

🎉 This PR is included in version 1.91.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[experimental] RPC error code leaks to @solana/errors decode command
1 participant