PR feedback. Formatting and comments

ci/test-checks.sh

@@ -75,7 +75,7 @@ nightly_clippy_allows=(
 
   # This link seems to incorrectly trigger in
   # `programs/bpf_loader/src/syscalls/{lib,cpi}.rs`
-  "--allow=clippy::explicit-auto-deref"
+  "--allow=clippy::explicit_auto_deref"
 )
 
 # -Z... is needed because of clippy bug: https://github.com/rust-lang/rust-clippy/issues/4612

runtime/src/in_mem_accounts_index.rs

@@ -1416,9 +1416,10 @@ impl<'a> FlushGuard<'a> {
     /// Set the `flushing` atomic flag to true.  If the flag was already true, then return `None`
     /// (so as to not clear the flag erroneously).  Otherwise return `Some(FlushGuard)`.
     #[must_use = "if unused, the `flushing` flag will immediately clear"]
-    #[allow(clippy::unnecessary_lazy_evaluations)]
     fn lock(flushing: &'a AtomicBool) -> Option<Self> {
         let already_flushing = flushing.swap(true, Ordering::AcqRel);
+        // Eager evaluation here would result in dropping Self and clearing flushing flag
+        #[allow(clippy::unnecessary_lazy_evaluations)]
         (!already_flushing).then(|| Self { flushing })
     }
 }