Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

BPF C functions always inlined wastes space #2179

Closed
3 tasks done
jackcmay opened this issue Dec 14, 2018 · 1 comment · Fixed by #10038
Closed
3 tasks done

BPF C functions always inlined wastes space #2179

jackcmay opened this issue Dec 14, 2018 · 1 comment · Fixed by #10038
Assignees
Milestone

Comments

@jackcmay
Copy link
Contributor

jackcmay commented Dec 14, 2018

Problem

All BPF C functions are currently inlined which wastes space

Proposed Solution

Remove Solana function prefix:
#define SOL_FN_PREFIX __attribute__((always_inline)) static
Or, at least redefine to remove inlining:
#define SOL_FN_PREFIX static

Depends on:

@jackcmay
Copy link
Contributor Author

jackcmay commented Feb 4, 2019

This is an optimization and lower priority and not critical for Beacons, removing the Beacons Milestone

@jackcmay jackcmay removed this from the v0.12 Beacons milestone Feb 4, 2019
@mvines mvines added this to the The Future! milestone Apr 8, 2019
@mvines mvines modified the milestones: The Future!, v1.3.0 May 27, 2020
ripatel-fd pushed a commit to ripatel-fd/solana that referenced this issue Aug 8, 2024
…5519 precompile (backport of solana-labs#1876) (solana-labs#2179)

[ed25519] Use `verify_strict` for signature verification in ed25519 precompile (solana-labs#1876)

* use `verify_strict` for signature verification in ed25519 precompile

* add test

* clippy

* increase ed25519 precompile cost constant by 5%

* put ed25519 strict verification cost change under feature gate

---------

Co-authored-by: Emanuele Cesena <[email protected]>
(cherry picked from commit ddda6c3)

Co-authored-by: samkim-crypto <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants