This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add solana-tokens #10011
Merged
Add solana-tokens #10011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ThinClient methods to implement --no-wait * Plumb --no-wait through No tests yet * Check transaction status on startup * Easier to test * Wait until transaction is finalized before checking if it failed with an error It's possible that a minority fork thinks it failed. * Add unit tests * Remove dead code and rustfmt * Don't flush database to file if doing a dry-run
If those transactions are dropped, the next run will execute them.
Delete the copy-pasted top-level test. Fixes solana-labs#19
* Move resolve_distribute_stake_args into its own function * Add stake args to token args * Unify option names * Move Command::DistributeStake into DistributeTokens * Remove process_distribute_stake * Only unique signers * Use sender keypair to fund new fee-payer accounts * Unify distribute_tokens and distribute_stake
* Send all transactions as quickly as possible, then wait * Exit when finalized or blockhashes have expired * Don't need blockhash in the CSV output * Better types CSV library was choking on Pubkey as a type. PickleDb doesn't have that problem. * Resend if blockhash has not expired * Attempt to fix CI
* Add constructor, tuck away client * Fix unwrap() caught by CI
* Remove untested --no-wait feature * Make --transactions-db an option, not an arg So that in the future, we can make it optional * Remove more untested features Too many false positives in that santity check. Use --dry-run instead. * Add dry-run mode to ThinClient * Cleaner dry-run * Make key parameters required Just don't use them in --dry-run * Add option to write the transaction log --dry-run doesn't write to the database. Use this option if you want a copy of the transaction log before the final run. * Revert --transaction-log addition Implement solana-labs#27 first * Fix CI * Update readme * Fix CI in copypasta
* Move db functionality into its own module * Rename tokens module to commands * Version bump * Upgrade Solana
garious
commented
May 12, 2020
| }; | ||
| use solana_transaction_status::TransactionStatus; | ||
|
|
||
| pub trait Client { |
There was a problem hiding this comment.
After this is merged, first course of action will be looking for ways to get rid of trait.
garious
commented
May 12, 2020
| impl Client for RpcClient { | ||
| fn send_transaction1(&self, transaction: Transaction) -> Result<Signature> { | ||
| self.send_transaction(&transaction) | ||
| .map_err(|e| TransportError::Custom(e.to_string())) |
There was a problem hiding this comment.
This is super ugly - will make it go away post-merge.
Codecov Report
@@ Coverage Diff @@
## master #10011 +/- ##
=======================================
Coverage 80.4% 80.4%
=======================================
Files 292 292
Lines 67293 67293
=======================================
Hits 54140 54140
Misses 13153 13153 |
|
Do we want to ship |
mvines
approved these changes
May 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I've been developing the CLI tool
solana-tokensin a separate repo, which was great for its initial development, but now it's more important that it doesn't bitrot at we change solana APIs.Summary of Changes