This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Ledger-tool: only require ledger dir when necessary #21575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
added
v1.8
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
|
Flaky local-cluster |
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2021
* Don't canonicalize ledger_path unless ledger_path will be used * Single use statement (cherry picked from commit 2b269db) # Conflicts: # ledger-tool/src/main.rs
mergify bot
added a commit
that referenced
this pull request
Dec 3, 2021
…#21578) * Ledger-tool: only require ledger dir when necessary (#21575) * Don't canonicalize ledger_path unless ledger_path will be used * Single use statement (cherry picked from commit 2b269db) # Conflicts: # ledger-tool/src/main.rs * Fix conflicts Co-authored-by: Tyera Eulberg <[email protected]> Co-authored-by: Tyera Eulberg <[email protected]>
jbiseda
pushed a commit
to jbiseda/solana
that referenced
this pull request
Dec 6, 2021
* Don't canonicalize ledger_path unless ledger_path will be used * Single use statement
t-nelson
added a commit
to t-nelson/solana
that referenced
this pull request
Dec 13, 2021
…olana-labs#21575) (solana-labs#21578)" This reverts commit 5a7b487.
tao-stones
pushed a commit
that referenced
this pull request
Dec 13, 2021
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 16, 2021
…backport solana-labs#21575) (solana-labs#21578)"" This reverts commit eae3166.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#15808 improved the ergonomics of solana-ledger-tool by adding a default ledger path, but the tool will always exit if the ledger path does not exist. This is annoying when using
solana-ledger-tool bigtable, since most of the subcommands read only from BigTable and don't open the local ledger at all. The current workaround is to create aledgerdir in CWD, or always pass-l <PATH_TO_SOMETHING_THAT_DOES_EXIST>. Yuck.Summary of Changes
Only canonicalize the ledger_path when ledger_path will actually be used
Also convert this crate to a single use statement, while I'm in the area