Add Ident case to respan procedural macro
#24390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaron1011
approved these changes
Apr 15, 2022
CriesofCarrots
added
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #24390 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 582 582
Lines 162388 162392 +4
=========================================
- Hits 133397 133396 -1
- Misses 28991 28996 +5 |
mergify bot
pushed a commit
that referenced
this pull request
Apr 15, 2022
(cherry picked from commit a0e3e3c)
mergify bot
pushed a commit
that referenced
this pull request
Apr 15, 2022
(cherry picked from commit a0e3e3c)
CriesofCarrots
pushed a commit
that referenced
this pull request
Apr 16, 2022
(cherry picked from commit a0e3e3c) Co-authored-by: Tyera Eulberg <[email protected]>
CriesofCarrots
pushed a commit
that referenced
this pull request
Apr 16, 2022
(cherry picked from commit a0e3e3c) Co-authored-by: Tyera Eulberg <[email protected]>
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 23, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 23, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 23, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 28, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 28, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 28, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 28, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana-ledger doesn't compile on Rust 1.61.0-nightly (76d770ac2 2022-04-02) and later. This is because of the
respanprocedural macro and this change: rust-lang/rust#95571respanexpects the module$nameto parse as a None-delimited Group, but it is now parsing as an Ident.Docs for solana-ledger and all crates that depend on it are hence broken, since docs.rs uses recent nightly for builds.
Summary of Changes
Add Ident case to match statement
@Aaron1011 , I wonder if you could take a look at this? Looks like you wrote our respan macro (thank you!), and also approved the rust-lang/rust#95571 change
Fixes #24361