This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Revive payments via Budget #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3079 +/- ##
========================================
- Coverage 77.7% 77.1% -0.7%
========================================
Files 137 137
Lines 20314 20486 +172
========================================
+ Hits 15789 15799 +10
- Misses 4525 4687 +162 |
steviez
added a commit
to steviez/solana
that referenced
this pull request
Oct 11, 2024
Use the tar crate instead; doing so avoids spawning a subprocess and also removes the variability of relying on whatever tar the caller has in their path
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Budget used to be part of the bank and was well-tested at that time. When we added
userdatato accounts, we moved it out and added a bunch of unit-tests, but no integration tests. Then we added support for batched instructions, and the current code doesn't reflect that. It still assumeskey[0]was the account that funded the program account. Also, BudgetTransaction doesn't allocate space for the program account.Summary of Changes
budget_state.rsto budget_api, where it can be used to calculate its serialized size to create the transactionStill quite a bit of work to do in a follow-up PR. It doesn't support more advanced contracts. BudgetInstruction needs to collect all potential Payment Pubkeys.