This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Define bank_snapshots_dir as tmpdir #31216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangzhu70
changed the title
xiangzhu70
changed the title
Codecov Report
@@ Coverage Diff @@
## master #31216 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 729 729
Lines 206332 206328 -4
=======================================
+ Hits 168277 168282 +5
+ Misses 38055 38046 -9 |
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Apr 17, 2023
* Let bank_snapshots_dir be TempDir * Same change in test_bank_from_latest_snapshot_dir * Use borrow to avoid releasing the tmp dir * One more to change to reference
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As pointed in #31191 (comment), the bank_snapshots_dir can be a TempDir directly. So some old code doing that wrong need to be cleaned up.
Summary of Changes
Let bank_snapshots_dir be defined as TempDir.
Fixes #