Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Refactor the common test snapshot dirs creation code #31223

Merged

Conversation

xiangzhu70
Copy link
Contributor

Problem

Multiple test cases have duplicated common code for creating test snapshot dirs in PRE or POST states.

Summary of Changes

Created a function create_snapshot_dirs_for_tests to refactor the common code for creating test snapshot dirs in any numbers of PRE or POST states.

Fixes #

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #31223 (074dd57) into master (f066ea9) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #31223     +/-   ##
=========================================
- Coverage    81.5%    81.5%   -0.1%     
=========================================
  Files         729      729             
  Lines      206466   206425     -41     
=========================================
- Hits       168366   168296     -70     
- Misses      38100    38129     +29     

@xiangzhu70 xiangzhu70 requested a review from apfitzge April 17, 2023 20:58
@xiangzhu70 xiangzhu70 marked this pull request as ready for review April 17, 2023 20:58
@xiangzhu70 xiangzhu70 requested a review from brooksprumo April 17, 2023 20:58
@xiangzhu70 xiangzhu70 merged commit 667fad6 into solana-labs:master Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants