This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
removes repair socket from gossip ContactInfo #32831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
rm-contact-info-repair
branch
from
bddaedc to
3fd1544
Compare
behzadnouri
force-pushed
the
rm-contact-info-repair
branch
from
3fd1544 to
ade1fd1
Compare
Repair responses are sent back to the address the repair request came from and there is no need to gossip repair socket address. https://github.com/solana-labs/solana/blob/9212ac347/core/src/repair/serve_repair.rs#L519
behzadnouri
force-pushed
the
rm-contact-info-repair
branch
from
ade1fd1 to
0a1250e
Compare
gregcusack
reviewed
Aug 14, 2023
| @@ -27,8 +27,7 @@ pub struct LegacyContactInfo { | |||
| tvu: SocketAddr, | |||
| /// TVU over QUIC protocol. | |||
| tvu_quic: SocketAddr, | |||
| /// address to send repair responses to | |||
| repair: SocketAddr, | |||
| unused: SocketAddr, | |||
There was a problem hiding this comment.
any reason why this is needed instead of getting fully removed? legacy purposes? -> legacy validators contacting this validator?
There was a problem hiding this comment.
It won't be backward compatible to remove it because we are using bincode for serialization which does not including any tags or schema in the serialized payload.
So if we remove it new code and old code will deserialize the same bytes differently.
Codecov Report
@@ Coverage Diff @@
## master #32831 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 785 785
Lines 211937 211927 -10
=======================================
- Hits 173833 173829 -4
+ Misses 38104 38098 -6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Repair responses are sent back to the address the repair request came from and there is no need to gossip repair socket address. https://github.com/solana-labs/solana/blob/9212ac347/core/src/repair/serve_repair.rs#L519
Summary of Changes
Removed repair socket from gossip
ContactInfo.