This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Refactor - Move interfaces of address-lookup-table into the program SDK #33165
Merged
Lichtso
merged 8 commits into
solana-labs:master
from
Lichtso:refactor/move_address_lookup_table_into_sdk
Sep 11, 2023
Merged
Refactor - Move interfaces of address-lookup-table into the program SDK #33165
Lichtso
merged 8 commits into
solana-labs:master
from
Lichtso:refactor/move_address_lookup_table_into_sdk
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d00b963
to
f5dde5d
Compare
6537ec4
to
d4f9f46
Compare
Codecov Report
@@ Coverage Diff @@
## master #33165 +/- ##
=========================================
- Coverage 82.0% 81.9% -0.2%
=========================================
Files 785 785
Lines 211122 212603 +1481
=========================================
+ Hits 173328 174156 +828
- Misses 37794 38447 +653 |
t-nelson
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better organization, imo! just a couple deprecation nits
d4f9f46
to
bf54c55
Compare
t-nelson
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! i'm r+ now. ping me if no one dissents or approves in 24hrs and i'll approve
Thanks for preserving the existing public interface |
t-nelson
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was referenced Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unlike the other built-in programs the address-lookup-table does not have a module in the program SDK. Instead other crates which depend on it use its program crate directly, which leads to dependency bloat: E.g. they implicitly also gain the entire program-runtime as a transitive dependency.
Summary of Changes
Moves
error
,state
andinstruction
of address-lookup-table from its program crate into the program SDK.