Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Minor cleanup on some snapshot related tests #33485

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

steviez
Copy link
Contributor

@steviez steviez commented Oct 2, 2023

Summary of Changes

  • Add test coverage for incremental snapshot redirect
  • Switch snapshot compression type to Tar in unit tests
  • Remove an incorrect comment about compression type on test-validator

- Add test coverage for incremental snapshot redirect
- Switch snapshot compression type to Tar in unit tests
- Remove an incorrect comment about compression type on test-validator
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #33485 (bb1d0a3) into master (3508b7d) will decrease coverage by 0.1%.
Report is 1 commits behind head on master.
The diff coverage is 83.3%.

@@            Coverage Diff            @@
##           master   #33485     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         802      802             
  Lines      217801   217802      +1     
=========================================
- Hits       178114   178105      -9     
- Misses      39687    39697     +10     

@steviez steviez requested a review from brooksprumo October 2, 2023 17:45
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@steviez steviez merged commit 3eae980 into solana-labs:master Oct 2, 2023
@steviez steviez deleted the snap_test_cleanup branch October 2, 2023 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants