This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Adds solana-nohash-hasher #33521
Merged
Adds solana-nohash-hasher #33521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
nohash/add
branch
from
1e3da11 to
e0889e2
Compare
brooksprumo
added
the
automerge
This was referenced Oct 4, 2023
This was referenced Oct 4, 2023
tao-stones
pushed a commit
to tao-stones/solana
that referenced
this pull request
Oct 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In accounts-db, we make lists of slots for various tasks. We put these in HashSets/HashMaps, which perform cryptographically secure hashing of the keys. Since we (1) don't always require cryptographic security, and (2) know that slots are unique identifiers, we actually don't need to hash the slot at all, but instead can use it directly.
The
solana-nohash-hashercrate was designed for this.Summary of Changes
Add solana-nohash-hasher to accounts-db.
Future PRs will use solana-nohash-hasher—explicitly not included in this PR.