This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
stop padding new append vecs to page size #33607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems a bench test failed. [2023-10-09T23:01:42.809916369Z ERROR solana_accounts_bench] results different: | (AccountsHash(3T99DHTbjqBrqnUEBzAng7rZgdyVDwDNf5eY4HGR6pHi), 12505000) |
Codecov Report
@@ Coverage Diff @@
## master #33607 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 807 807
Lines 218252 218263 +11
=======================================
+ Hits 178438 178456 +18
+ Misses 39814 39807 -7 |
steviez
pushed a commit
to steviez/solana
that referenced
this pull request
Oct 10, 2023
This reverts commit b7962a3.
steviez
pushed a commit
that referenced
this pull request
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We no longer 'append' to append vecs. We know the full size when we are ready to write to them. So, it is no longer necessary to pad them to the next full page size. This makes 100% of the data in the file required and the used length equal to the allocated length.
Summary of Changes
Fixes #