This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
geyser: add is_reload argument to on_load
#33674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
stale
|
This changes the interface. Why does a plugin care about if it is reload or a new load? |
github-actions
bot
removed
the
stale
The plugin can have a special logic for accounts from snapshot and will not work on reloading / loading through rpc. |
lijunwangs
suggested changes
Nov 14, 2023
|
Updated! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #33674 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 811 811
Lines 219628 219628
=========================================
- Hits 179974 179926 -48
- Misses 39654 39702 +48 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Plugins are not able to distinguish loading and reloading.
Summary of Changes
Add
is_reloadargument toon_loadplugin function.