Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Docker images > 1.17.0 are broken because of wrong baseimage #33709

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

TPXP
Copy link
Contributor

@TPXP TPXP commented Oct 16, 2023

Problem

The last solana images are built with Rust 1.73.0 for which the default debian image is based on Bookworkm, but the binaries are copied to an image based on bullseye.

Consequently, the build binaries expect GLIBC 2.34 while Bullseye ships 2.31.

Summary of Changes

Solana's release image is based on bullseye, make sure we compile Solana with the same environment

Fixes #33673

Another approach could be to set this tag and the one in the docker image build to bookworm. In any case, let's make sure the tags are consistent and explicitly pin a debian destro though :)

Solana's release image is based on bullseye, make sure we compile Solana with the same environment
@mergify mergify bot added community Community contribution need:merge-assist labels Oct 16, 2023
@mergify mergify bot requested a review from a team October 16, 2023 09:32
@zb-polysign
Copy link

Do we have an ETA on when this might get merged and rolled out?

@rguichard
Copy link

Image builds for 1.17.1 and 1.17.2 are broken without this fix. Can we have someone to take a look and review this PR ?

@TPXP TPXP changed the title fix(dockerfile): make sure to use the bullseye image for building Docker images > 1.17.0 are broken because of wrong baseimage Oct 20, 2023
@yihau yihau added the CI Pull Request is ready to enter CI label Oct 20, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Oct 20, 2023
Copy link
Contributor

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@yihau yihau merged commit 96052d2 into solana-labs:master Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Community contribution need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solana v1.17.1 GLIBC not found
5 participants