This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
add metric for ancient can't move slots #33713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
reviewed
Oct 16, 2023
HaoranYi
previously approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #33713 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 806 806
Lines 217867 217875 +8
=======================================
+ Hits 178260 178307 +47
+ Misses 39607 39568 -39 |
brooksprumo
previously approved these changes
Oct 16, 2023
brooksprumo
reviewed
Oct 16, 2023
brooksprumo
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we are packing ancient append vecs, the current strategy is to not move accounts from a slot for all accounts with refcounts > 1. This is because we can't know easily what other slot(s) the older versions of the account are in. Thus, it isn't safe to move slots.
Summary of Changes
Add a metric to keep track of how many slots fit this criteria.
Fixes #