This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
log ancient stats each time we run #33730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33730 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 806 806
Lines 217862 217860 -2
=======================================
+ Hits 178242 178245 +3
+ Misses 39620 39615 -5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ancient append vec packing is now running at a reasonable interval (similar to when clean runs). As a result, we should now log the metrics each time it completes. It is not uncommon for ancient append vec packing to do nothing. In those cases, we still need to log how much time the algorithms spent trying to pack.
Summary of Changes
Log each time ancient append vec packing runs.
Fixes #