This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
ancient: add many_refs_this_is_newest_alive #33741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
oc10
branch
2 times, most recently
from
478921b to
f056c58
Compare
Codecov Report
@@ Coverage Diff @@
## master #33741 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 806 806
Lines 218058 218015 -43
=========================================
- Hits 178415 178367 -48
- Misses 39643 39648 +5 |
jeffwashington
commented
Oct 19, 2023
| } | ||
| fn with_capacity(capacity: usize, slot: Slot) -> Self { | ||
| Self { | ||
| one_ref: AliveAccounts::with_capacity(capacity, slot), | ||
| many_refs: AliveAccounts::with_capacity(capacity, slot), | ||
| many_refs_this_is_newest_alive: AliveAccounts::with_capacity(0, slot), |
There was a problem hiding this comment.
expectation is there are few accounts with ref_count > 1, so set capacity to 0.
HaoranYi
reviewed
Oct 19, 2023
brooksprumo
reviewed
Oct 20, 2023
jeffwashington
changed the title
|
rebased to fix merge errors with the |
brooksprumo
reviewed
Oct 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we disable rewrites, we will accumulate old append vecs & slots. We use ancient append vec packing to combine those. There exist many accounts which will remain in their dead state indefinitely.
Summary of Changes
Allow accounts which are alive and alive at the newest slot to still get packed together and move slots.
Fixes #