This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
CLI remove unwrap_or_default() on rpc calls #33782
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When calling some cli commands it might return an incorrect results because the RPC node calls failures are swallowed silently
Running this several times illustrates the problem, some features are disappearing
solana feature status -um
Doesn't work well because of the limitation of the public RPC, as a result the printed result is quite unstableSummary of Changes
Avoid
.unwrap_or_default()
?
instead to propagate the errorNow the CLI call above gives
Error: RPC response error -32602: Too many inputs provided; max 5
Fixes #