Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Crates have identical build.rs to frozen-abi can just be symlink #33787

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

tao-stones
Copy link
Contributor

@tao-stones tao-stones commented Oct 20, 2023

Problem

Some of crates' build.rs are symlinks to frozen-abi/build.rs, yet others have a full copy of it.

$ find . -name 'build.rs' -exec ls -la "{}" \;
-rw-r--r-- 1 sol users 1414 Sep 18 15:49 ./programs/bpf_loader/gen-syscall-list/build.rs
-rw-r--r-- 1 sol users 4128 Sep 25 23:11 ./programs/sbf/build.rs
lrwxrwxrwx 1 sol sol 25 Dec  9  2022 ./programs/stake/build.rs -> ../../frozen-abi/build.rs
lrwxrwxrwx 1 sol sol 25 Dec  9  2022 ./programs/vote/build.rs -> ../../frozen-abi/build.rs
lrwxrwxrwx 1 sol sol 25 Dec  9  2022 ./programs/address-lookup-table/build.rs -> ../../frozen-abi/build.rs
-rw-r--r-- 1 sol users 347 May  5 17:32 ./install/build.rs
lrwxrwxrwx 1 sol sol 22 Dec  9  2022 ./core/build.rs -> ../frozen-abi/build.rs
-rw-r--r-- 1 sol users 1000 Sep 18 15:49 ./storage-proto/build.rs
lrwxrwxrwx 1 sol sol 22 Dec  9  2022 ./bloom/build.rs -> ../frozen-abi/build.rs
lrwxrwxrwx 1 sol sol 22 Dec  9  2022 ./gossip/build.rs -> ../frozen-abi/build.rs
-rw-r--r-- 1 sol users 1383 Oct 19 22:41 ./perf/build.rs
lrwxrwxrwx 1 sol sol 22 Dec  9  2022 ./runtime/build.rs -> ../frozen-abi/build.rs
lrwxrwxrwx 1 sol sol 22 Dec  9  2022 ./version/build.rs -> ../frozen-abi/build.rs
lrwxrwxrwx 1 sol sol 25 Dec  9  2022 ./sdk/program/build.rs -> ../../frozen-abi/build.rs
lrwxrwxrwx 1 sol sol 22 Dec  9  2022 ./sdk/build.rs -> ../frozen-abi/build.rs
lrwxrwxrwx 1 sol sol 22 Dec  9  2022 ./program-runtime/build.rs -> ../frozen-abi/build.rs
-rw-r--r-- 1 sol users 1065 Sep 25 15:21 ./vote/build.rs
-rw-r--r-- 1 sol users 1065 May  5 17:32 ./ledger/build.rs
lrwxrwxrwx 1 sol sol 11 Dec  9  2022 ./frozen-abi/macro/build.rs -> ../build.rs
-rw-r--r-- 1 sol users 1065 May  5 17:32 ./frozen-abi/build.rs
-rw-r--r-- 1 sol users 563 Oct 19 22:41 ./wen-restart/build.rs
-rw-r--r-- 1 sol users 1065 Sep 18 15:49 ./accounts-db/build.rs
-rw-r--r-- 1 sol users 1065 Sep 18 15:49 ./cost-model/build.rs

Summary of Changes

  • change those have identical content to be symlink to frozen-abi/build.rs

Fixes #

@tao-stones tao-stones changed the title all build.rs should be symlink to frozen-abi/build.rs Crates have identical build.rs to frozen-abi can just be symlink Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #33787 (0f11542) into master (c98c24b) will increase coverage by 0.0%.
Report is 5 commits behind head on master.
The diff coverage is 97.0%.

@@           Coverage Diff           @@
##           master   #33787   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         806      806           
  Lines      218058   218106   +48     
=======================================
+ Hits       178415   178483   +68     
+ Misses      39643    39623   -20     

@tao-stones tao-stones merged commit af9c754 into solana-labs:master Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants