This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
improve batch_send error handling #33936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbiseda
force-pushed
the
jbiseda/batch_send-err
branch
from
10aa67f to
afcdf7b
Compare
Codecov Report
@@ Coverage Diff @@
## master #33936 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 809 809
Lines 218241 218255 +14
=========================================
- Hits 178794 178773 -21
- Misses 39447 39482 +35 |
ilya-bobyr
approved these changes
Nov 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
batch_send()andmulti_target_send()error handling is fragile.Summary of Changes
Update error handling to
matchstatement. Adding new error return codes will cause compilation failure.Fixes #