Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Add Blockstore::get_rooted_block_with_entries method #33995

Merged

Conversation

CriesofCarrots
Copy link
Contributor

Problem

There is interest in storing entry data in BigTable for redundancy. The BigTable uploader uses Blockstore::get_rooted_block() which flattens all the transactions in the block. But since it's already looping through all entries, this seems like the right place to collect Entry data as well.

Summary of Changes

Add helper structs and method to support a new Blockstore::get_rooted_block_with_entries()

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #33995 (5bce7e4) into master (06884a0) will decrease coverage by 0.1%.
Report is 6 commits behind head on master.
The diff coverage is 56.2%.

@@            Coverage Diff            @@
##           master   #33995     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         811      811             
  Lines      219339   219366     +27     
=========================================
+ Hits       179699   179717     +18     
- Misses      39640    39649      +9     

ledger/src/blockstore.rs Show resolved Hide resolved
ledger/src/blockstore.rs Outdated Show resolved Hide resolved
ledger/src/blockstore.rs Show resolved Hide resolved
ledger/src/blockstore.rs Show resolved Hide resolved
ledger/src/blockstore.rs Outdated Show resolved Hide resolved
ledger/src/blockstore.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Apologies for the wild goose chase on one or two of those comments!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants