This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
reduce locking in propagated check for VoteStateUpdate #33997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
force-pushed
the
vote-listener-filter
branch
from
302d55b to
59bf14f
Compare
AshwinSekar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #33997 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 811 811
Lines 219424 219497 +73
=======================================
+ Hits 179761 179830 +69
- Misses 39663 39667 +4 |
carllin
reviewed
Nov 10, 2023
| @@ -733,6 +752,8 @@ impl ClusterInfoVoteListener { | |||
| .or_insert(is_gossip_vote); | |||
| } | |||
|
|
|||
| *latest_vote_slot = max(*latest_vote_slot, last_vote_slot); | |||
|
|
|||
| if is_new_vote { | |||
| subscriptions.notify_vote(*vote_pubkey, vote, vote_transaction_signature); | |||
There was a problem hiding this comment.
Do we need to move this RPC notification before the new check as well so that we still get notified of last voted slots X in votes where X < latest_vote_slot
There was a problem hiding this comment.
This RPC notification is outside the loop, the behavior should remain unchanged. If the last vote was for a new slot as decided by the vote tracker, it will still notify.
There was a problem hiding this comment.
ah dam the github formatting messed me up, thanks
carllin
previously approved these changes
Nov 11, 2023
AshwinSekar
force-pushed
the
vote-listener-filter
branch
from
59bf14f to
29a33f9
Compare
carllin
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
logic is not updated for
VoteStateUpdate, end up checking all 31 slots every time which grabs the lock shared with replaySummary of Changes
filter out seen slots, no need to be precise and check every single slot, can filter by latest slot because propagated check rolls up to parent anyway.
potentially helps #33017