Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

storage-bigtable: Return error if attempting to write to table NotFound #34098

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

CriesofCarrots
Copy link
Contributor

Problem

I'm working on adding support for bigtable uploads to include entries. This will require users to add an entries table to their bigtable instances. Currently, our storage-bigtable write apis retry with exponential backoff, and will retry forever without reporting errors. This means that users who run the new entries upload code without having prepped the table will see their bigtable-uploader hang with no indication why.

Summary of Changes

Return backoff::Error::Permanent when a table isn't found so that retry halts and an error is actually printed.
Some kind of general error tracing across all the places we use retry would probably be helpful, but this seems like a reasonable short circuit.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #34098 (32294bf) into master (061883e) will increase coverage by 0.0%.
Report is 7 commits behind head on master.
The diff coverage is 0.0%.

❗ Current head 32294bf differs from pull request most recent head 33f2c58. Consider uploading reports for the commit 33f2c58 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34098   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         812      812           
  Lines      219645   219653    +8     
=======================================
+ Hits       179922   179975   +53     
+ Misses      39723    39678   -45     

storage-bigtable/src/bigtable.rs Outdated Show resolved Hide resolved
storage-bigtable/src/bigtable.rs Outdated Show resolved Hide resolved
storage-bigtable/src/bigtable.rs Outdated Show resolved Hide resolved
@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Nov 16, 2023
@mergify mergify bot merged commit 6fc6a49 into solana-labs:master Nov 16, 2023
18 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants