This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
storage-bigtable: Return error if attempting to write to table NotFound #34098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I'm working on adding support for bigtable uploads to include entries. This will require users to add an
entries
table to their bigtable instances. Currently, our storage-bigtable write apis retry with exponential backoff, and will retry forever without reporting errors. This means that users who run the new entries upload code without having prepped the table will see their bigtable-uploader hang with no indication why.Summary of Changes
Return
backoff::Error::Permanent
when a table isn't found so that retry halts and an error is actually printed.Some kind of general error tracing across all the places we use
retry
would probably be helpful, but this seems like a reasonable short circuit.