This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@yihau I know you've already seen this PR; can you update the CI agents with this new rust? |
sure! just restarted your pipeline! |
Current clippy build error is getting fixed here: #34119 |
brooksprumo
force-pushed
the
rust/1.74.0
branch
from
November 16, 2023 20:29
c099467
to
9ef7409
Compare
Fixing bigtable clippy error here: #34126 |
brooksprumo
force-pushed
the
rust/1.74.0
branch
2 times, most recently
from
November 18, 2023 00:40
d4f2dde
to
3c0efbb
Compare
brooksprumo
force-pushed
the
rust/1.74.0
branch
from
November 18, 2023 17:06
3c0efbb
to
46ae7a8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34118 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 819 819
Lines 220120 219077 -1043
=========================================
- Hits 180367 179295 -1072
- Misses 39753 39782 +29 |
yihau
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪖
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html