This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Refactor - ExtractedPrograms
#34205
Merged
Refactor - ExtractedPrograms
#34205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34205 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 819 819
Lines 219425 219338 -87
=========================================
- Hits 179854 179724 -130
- Misses 39571 39614 +43 |
pgarg66
approved these changes
Nov 23, 2023
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
* Puts ExtractedPrograms into Arc<Mutex<>>. * Merges ExtractedPrograms::missing and ExtractedPrograms::unloaded. * Unifies missing entry insertion in LoadedPrograms::extract(). (cherry picked from commit 4ee5078)
Lichtso
added a commit
that referenced
this pull request
Dec 14, 2023
* Puts ExtractedPrograms into Arc<Mutex<>>. * Merges ExtractedPrograms::missing and ExtractedPrograms::unloaded. * Unifies missing entry insertion in LoadedPrograms::extract(). (cherry picked from commit 4ee5078)
Lichtso
added a commit
that referenced
this pull request
Dec 14, 2023
Refactor - `ExtractedPrograms` (#34205) * Puts ExtractedPrograms into Arc<Mutex<>>. * Merges ExtractedPrograms::missing and ExtractedPrograms::unloaded. * Unifies missing entry insertion in LoadedPrograms::extract(). (cherry picked from commit 4ee5078) Co-authored-by: Alexander Meißner <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Preparation for #33715.
Summary of Changes
ExtractedProgramsintoArc<Mutex<>>because when TX batches cooperate they need to access each others results in order to complete them.ExtractedPrograms::missingandExtractedPrograms::unloadedto deduplicate code paths.LoadedPrograms::extract(), so that there is one point where in a subsequent PR we could check if another TX batch is already loading the missing entry.