This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Uses Display for error in VerifyAccountsHashInBackground's panic message #34219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the initial accounts hash verification fails, the panic message prints out the error, but with
Debug
. This may not include useful information thatDisplay
would. Since this message is user/dev-facing,Display
is more helpful.Summary of Changes
Change the error to be printed with
Display
instead ofDebug
.Also, change the panic text to match the logs when the bg process starts/stops:
solana/runtime/src/bank.rs
Line 7165 in c6451e9
Backports
I'd also like to backport this to v1.17, to aid in debugging any issues sooner.