This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
add slot to assert message #34225
Merged
add slot to assert message #34225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
previously approved these changes
Nov 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34225 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 819 819
Lines 219302 219306 +4
=======================================
+ Hits 179619 179693 +74
+ Misses 39683 39613 -70 |
brooksprumo
approved these changes
Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Several recent reports of hitting these asserts while testing. It would be useful to know what slot. This helps us know where the slot is relative to the last clean, newest root, etc.
Summary of Changes
Add
slotto assert message.Fixes #