This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
ledger-tool does *not* fastboot by default #34228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fastboot is great for the validator, but can expose some sharp edges for ledger-tool. If a validator is already running, then calling ledger-tool will fail (on the subcommand that use accounts) due to the default fastboot value (since it tries to get primary access to the ledger). The error message does not make it obvious what the problem is, nor how to fix it.
Summary of Changes
Do not fastboot by default for ledger-tool.
This is safe, and retains the expectation that ledger-tool should not modify anything by default. Users can still opt into fastboot with ledger-tool.