Patch tokio to vendored version #34240
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34240 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 819 819
Lines 219387 219387
=======================================
Hits 179732 179732
Misses 39655 39655 |
|
@CriesofCarrots - Moving some discussion from Discord to here, do you think we should "finish the revert" in light of you finding that piece of the commit that I missed? The revert seemed to help as-is, but I still feel like we should fix the mistake. Assuming you agree with fixing that, I'm wondering if we should fix up the revert commit first, before moving to vendored tokio |
CriesofCarrots
force-pushed
the
patch-tokio
branch
from
6951211 to
c01e6d8
Compare
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
|
I took some extra time to confirm that this would not break downstream users pulling in solana client crates, the way that pinning the tokio version did. All built as expected. |
* Patch tokio to vendored version * Fix typo (cherry picked from commit aaa48ec) # Conflicts: # Cargo.toml
* Patch tokio to vendored version (#34240) * Patch tokio to vendored version * Fix typo (cherry picked from commit aaa48ec) # Conflicts: # Cargo.toml * Fix conflict --------- Co-authored-by: Tyera <[email protected]>
Problem
This issue still exists for RPC operators: #24644
Summary of Changes
Patch tokio to
solana-tokioat v1.29.1 with 4eed411 manually reverted