Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

TransactionScheduler: Schedule Filter #34252

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

apfitzge
Copy link
Contributor

@apfitzge apfitzge commented Nov 28, 2023

Problem

#34233 will filter transactions out before we become leader, but we still may receive filterable transactions during or very close to our leader slot.
We should be filtering these out before prio-graph insertion, so they do not block other transactions.

Summary of Changes

  • Add a generic filter to PrioGraph::schedule
  • Call Bank::check_transactions inside filter
  • Add filter count and time metrics
  • For efficiency in filter, do batched pops from the container to prio-graph

Fixes #

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #34252 (5ac9074) into master (e949ef9) will decrease coverage by 0.1%.
Report is 6 commits behind head on master.
The diff coverage is 94.8%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34252     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         819      819             
  Lines      219756   219814     +58     
=========================================
+ Hits       180115   180131     +16     
- Misses      39641    39683     +42     

@apfitzge apfitzge marked this pull request as ready for review November 29, 2023 21:25
@apfitzge apfitzge requested a review from tao-stones November 29, 2023 21:28
@apfitzge apfitzge requested a review from tao-stones November 30, 2023 19:49
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit 18309ba into solana-labs:master Nov 30, 2023
18 checks passed
@apfitzge apfitzge deleted the schedule_filter branch November 30, 2023 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants