Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

generalize message type for runtime-transaction #34276

Merged

Conversation

tao-stones
Copy link
Contributor

Problem

Generalize message type for RuntimeTransaction types could decouple sdk, also better reflect the nature relationship between Transaction and Message.

Summary of Changes

  • generalize RuntimeTransaction type

Fixes #

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #34276 (cbd3193) into master (8d7e63d) will increase coverage by 0.0%.
Report is 12 commits behind head on master.
The diff coverage is 89.9%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #34276    +/-   ##
========================================
  Coverage    81.9%    81.9%            
========================================
  Files         819      819            
  Lines      220228   220418   +190     
========================================
+ Hits       180556   180727   +171     
- Misses      39672    39691    +19     

@tao-stones tao-stones force-pushed the runtime-transaction-generic branch from be97ec4 to 3344e0c Compare December 5, 2023 17:04
@tao-stones tao-stones requested a review from apfitzge December 5, 2023 17:07
@tao-stones tao-stones force-pushed the runtime-transaction-generic branch from 3344e0c to 17223b8 Compare December 5, 2023 17:31
@tao-stones tao-stones requested a review from apfitzge December 6, 2023 15:56
Copy link
Contributor

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tao-stones tao-stones merged commit f6403e3 into solana-labs:master Dec 7, 2023
18 checks passed
@tao-stones tao-stones deleted the runtime-transaction-generic branch December 7, 2023 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants