This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Removes unnecessary new_sized() AccountsDb ctor #34504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34504 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 820 820
Lines 220790 220791 +1
=======================================
+ Hits 180679 180681 +2
+ Misses 40111 40110 -1 |
steviez
approved these changes
Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are a lot of AccountsDb constructors. This makes it hard for me to remember what each one uniquely does. Also, I'd like to remove all TempDirs from inside AccountsDb, and instead have a common harness that creates them as needed for tests/benches/etc. The abundance of AccountsDb/Accounts/Bank constructors makes this much harder.
Summary of Changes
Removes AccountsDb::new_sized() and updates callers.