cleanup feature code after activated everywhere #34509
Conversation
tao-stones
force-pushed
the
cleanup-feature-29881
branch
from
a624e80 to
739a290
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34509 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 820 820
Lines 220869 220857 -12
=========================================
- Hits 180788 180761 -27
- Misses 40081 40096 +15 |
tao-stones
requested review from
LucasSte,
pgarg66 and
steviez
and removed request for
LucasSte
| @@ -82,18 +82,13 @@ impl FeeStructure { | |||
| message: &SanitizedMessage, | |||
| lamports_per_signature: u64, | |||
| budget_limits: &FeeBudgetLimits, | |||
| remove_congestion_multiplier: bool, | |||
| include_loaded_account_data_size_in_fee: bool, | |||
| ) -> u64 { | |||
| // Fee based on compute units and signatures | |||
| let congestion_multiplier = if lamports_per_signature == 0 { | |||
There was a problem hiding this comment.
which tests are affected by this remaining branch? Seems unecessary to have this branch with the concept of congestion multiplier removed.
good news is it's better now :D |
|
Was a tad late to the review, but looks good to me; sounds like Tao will address my last comment in a further comment: |
#34537 is the follow up PR to remove unnecessary parameter, leads to a great simplification of code |
Problem
Feature
A8xyMHZovGXFkorFqEmVH2PKGLiBip5JD7jt4zsUWo4HRemove congestion multiplier from transaction fee calculation #29881 has been activated everywhere.Summary of Changes
Fixes #