Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Upgrades Rust nightly to 2024-01-05 #34673

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

brooksprumo
Copy link
Contributor

No description provided.

@brooksprumo brooksprumo self-assigned this Jan 5, 2024
@brooksprumo
Copy link
Contributor Author

@yihau Can you upgrade the nightly rust on the CI machines, please? Thanks in advance! 👻

@yihau
Copy link
Contributor

yihau commented Jan 7, 2024

sure! just updated and re-run the pipeline 👻. unfortunately it is unsuccessful due to:

error: unnecessary braces around block return value
  --
  | --> program-runtime/src/invoke_context.rs:63:21
  |    \|
  | 63 \|                     $inner
  |    \|                     ^^^^^^
  |    \|
  | = note: `-D unused-braces` implied by `-D warnings`
  | = help: to override `-D warnings` add `#[allow(unused_braces)]`

@brooksprumo
Copy link
Contributor Author

just updated and re-run the pipeline 👻. unfortunately it is unsuccessful [..]

This has been fixed by #34681.

@brooksprumo
Copy link
Contributor Author

brooksprumo commented Jan 8, 2024

New build error for undefined behavior in program spoof tests is being tracked in #34687.

Edit: Fixed.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (896a531) 81.8% compared to head (3db84bb) 81.8%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34673     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         824      824             
  Lines      222692   222719     +27     
=========================================
- Hits       182270   182241     -29     
- Misses      40422    40478     +56     

@brooksprumo brooksprumo marked this pull request as ready for review January 9, 2024 14:00
@brooksprumo brooksprumo requested a review from yihau January 9, 2024 14:01
Copy link
Contributor

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

@brooksprumo brooksprumo merged commit 39976cc into solana-labs:master Jan 9, 2024
30 checks passed
@brooksprumo brooksprumo deleted the rust/nightly branch January 9, 2024 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants